linux-kernel - Re: [PATCH] Cleanup of rw_copy_check_uvector and compat_rw_copy_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120130140128.037aca27.akpm@linux-foundation.org>
Date:	Mon, 30 Jan 2012 14:01:28 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Christopher Yeoh <cyeoh@....ibm.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Cleanup of rw_copy_check_uvector and
 compat_rw_copy_check_uvector

On Mon, 30 Jan 2012 18:23:37 +0100
Oleg Nesterov <oleg@...hat.com> wrote:

> On 01/30, Christopher Yeoh wrote:
> >
> >  ssize_t compat_rw_copy_check_uvector(int type,
> >  		const struct compat_iovec __user *uvector, unsigned long nr_segs,
> >  		unsigned long fast_segs, struct iovec *fast_pointer,
> > -		struct iovec **ret_pointer, int check_access)
> > +		struct iovec **ret_pointer)
> >  {
> >  	compat_ssize_t tot_len;
> >  	struct iovec *iov = *ret_pointer = fast_pointer;
> > @@ -586,7 +586,7 @@ ssize_t compat_rw_copy_check_uvector(int type,
> >  		}
> >  		if (len < 0)	/* size_t not fitting in compat_ssize_t .. */
> >  			goto out;
> > -		if (check_access &&
> > +		if (type >=0 &&
> 
> I bet checkpatch.pl will complain, this needs the space after '>' ;)
> 
> Otherwise this is nice cleanup, imho.
> 
> Christopher, this is up to Andrew but perhaps you should update
> the changelog. It should explain what this patch does (overload
> "int type", remove the unnecessary "check_access", etc). It should
> not simply mention the previous discussion.
> 

Yes please.  Put oneself in the position of a developer reading the
changelog two years from now.

Also, please use our conventional comment layout style in fs.h.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/