lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20120130220426.4d4d48a7@pyramind.ukuu.org.uk>
Date:	Mon, 30 Jan 2012 22:04:26 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Jeroen Van den Keybus <jeroen.vandenkeybus@...il.com>
Cc:	linux-kernel@...r.kernel.org, Clemens Ladisch <clemens@...isch.de>,
	"Huang, Shane" <Shane.Huang@....com>,
	Borislav Petkov <bp@...64.org>,
	"Nguyen, Dong" <Dong.Nguyen@....com>, jesse.brandeburg@...il.com
Subject: Re: [PATCH] Unhandled IRQs on AMD E-450: temporarily switch to
 low-performance polling IRQ mode

> +				printk("Polling IRQ %d\n", irq);

printk levels would be good.


> -		__report_bad_irq(irq, desc, action_ret);
> +		/* __report_bad_irq(irq, desc, action_ret); */

And this removes debugging for a reason that isn't described ?


In general this looks sane although it may do bad stuff on some platforms
I guess - notably irqpoll has an x86 ism in it still that now may need
dealing with (the IRQ 0 magic)

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ