linux-kernel - Re: [BUGFIX][PATCH] pci: check for 4k resource_size alignment in sriov

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120130031845.GA2359@ram-ThinkPad-T61>
Date:	Mon, 30 Jan 2012 11:18:45 +0800
From:	Ram Pai <linuxram@...ibm.com>
To:	Vaidyanathan Srinivasan <svaidy@...ux.vnet.ibm.com>
Cc:	Ram Pai <linuxram@...ibm.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Yinghai Lu <yinghai.lu@...cle.com>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [BUGFIX][PATCH] pci: check for 4k resource_size alignment in
 sriov_init

On Sat, Jan 28, 2012 at 12:40:32AM +0530, Vaidyanathan Srinivasan wrote:
> Hi Ram and Jesse,
> 
> I found a trivial issue with page size alignment check on IBM POWER
> box with 64k base page size.  In sriov_init(), changing the check from
> PAGE_SIZE (arch and config dependent) to HW_PAGE_SIZE (always 4k) was
> required to use one of the sriov adapter as PF since the
> resource_size() comes up as 0x8000 and PAGE_SIZE would be 0x10000 for
> pseries boxes.
> 
> I think resource_size() could be less than SystemPageSize, but I would
> like your comments/ack/nack on any consequences of checking for only
> 4k alignment here in a system with larger base page size.

As per the SRIOV specs, the  resource has to be System page size aligned.

PFs are required to support 4-KB, 8-KB, 64-KB, 256-KB, 1-MB, and 4-MB
page sizes. In your case if your adapter's PF is not supporting 64K page size
then I think it is not conforming to the PCI SRIOV spec.

RP

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/