linux-kernel - Re: [PATCH] sched: At sched_fork use __set_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120131084830.GA22077@linux.vnet.ibm.com>
Date:	Tue, 31 Jan 2012 14:18:30 +0530
From:	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
To:	Rakib Mullick <rakib.mullick@...il.com>
Cc:	mingo@...e.hu, a.p.zijlstra@...llo.nl, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched: At sched_fork use __set_task_cpu().

* Rakib Mullick <rakib.mullick@...il.com> [2012-01-29 22:34:37]:

>  We don't use select_task_rq() from sched_fork() anymore and no chance of task gets migrated at
> this point. Therefore, we can avoid task migration related checking/accounting, so use
> __set_task_cpu() instead of set_task_cpu().
> 
> Signed-off-by: Rakib Mullick <rakib.mullick@...il.com>
  Reviewed-by: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
> ---
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index df00cb0..a38026e 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -1755,7 +1755,7 @@ void sched_fork(struct task_struct *p)
>  	 * Silence PROVE_RCU.
>  	 */
>  	raw_spin_lock_irqsave(&p->pi_lock, flags);
> -	set_task_cpu(p, cpu);
> +	__set_task_cpu(p, cpu);
>  	raw_spin_unlock_irqrestore(&p->pi_lock, flags);
> 
>  #if defined(CONFIG_SCHEDSTATS) || defined(CONFIG_TASK_DELAY_ACCT)
> 
> 
> --

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/