linux-kernel - Re: [PATCH v2] add LED driver for PCA9663 I2C chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120130163424.ef8eb9af.akpm@linux-foundation.org>
Date:	Mon, 30 Jan 2012 16:34:24 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Peter Meerwald <pmeerw@...erw.net>, linux-kernel@...r.kernel.org,
	lars@...afoo.de, rpurdie@...ys.net
Subject: Re: [PATCH v2] add LED driver for PCA9663 I2C chip

On Mon, 30 Jan 2012 16:28:49 -0800
Andrew Morton <akpm@...ux-foundation.org> wrote:

> > +exit:
> > +	while (i--) {
> > +		led_classdev_unregister(&pca9633[i].led_cdev);
> > +		cancel_work_sync(&pca9633[i].work);
> > +	}
> 
> This (untested!) loop has an off-by-one error. 

Well, it's partly wrong.  It's wrong for the cancel_work_sync() but not
for the led_classdev_unregister().  The cancel_work_sync() can just be
removed: we haven't scheduled any works yet.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/