linux-kernel - Re: [PATCH 05/16] cx18: fix handling of 'radio' module parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1328004803.2821.15.camel@palomino.walls.org>
Date:	Tue, 31 Jan 2012 05:13:22 -0500
From:	Andy Walls <awalls@...metrocast.net>
To:	Danny Kukawka <danny.kukawka@...ect.de>
Cc:	Rusty Russell <rusty@...tcorp.com.au>, mchehab@...hat.com,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	ivtv-devel@...vdriver.org, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/16] cx18: fix handling of 'radio' module parameter

On Tue, 2012-01-31 at 05:01 -0500, Andy Walls wrote:
> On Mon, 2012-01-30 at 20:40 +0100, Danny Kukawka wrote:
> > Fixed handling of 'radio' module parameter from module_param_array
> > to module_param_named to fix these compiler warnings in cx18-driver.c:
> 
> NACK.
> 
> "radio" is an array of tristate values (-1, 0, 1) per installed card:
> 
> 	static int radio[CX18_MAX_CARDS] = { -1, -1,
> 
> and must remain an array or you will break the driver.
> 
> Calling "radio_c" a module parameter named "radio" is wrong.
> 
> The correct fix is to reverse Rusty Russel's patch to the driver in
> commit  90ab5ee94171b3e28de6bb42ee30b527014e0be7
> to change the "bool" back to an "int" as it should be in
                      ^^^^
Sorry, a typo here.  Disregard the word "back".

Regards,
Andy

> "module_param_array(radio, ...)"
> 
> Regards,
> Andy
> 
> > In function ‘__check_radio’:
> > 113:1: warning: return from incompatible pointer type [enabled by default]
> > At top level:
> > 113:1: warning: initialization from incompatible pointer type [enabled by default]
> > 113:1: warning: (near initialization for ‘__param_arr_radio.num’) [enabled by default]
> > 
> > Signed-off-by: Danny Kukawka <danny.kukawka@...ect.de>
> > ---
> >  drivers/media/video/cx18/cx18-driver.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/media/video/cx18/cx18-driver.c b/drivers/media/video/cx18/cx18-driver.c
> > index 349bd9c..27b5330 100644
> > --- a/drivers/media/video/cx18/cx18-driver.c
> > +++ b/drivers/media/video/cx18/cx18-driver.c
> > @@ -110,7 +110,7 @@ static int retry_mmio = 1;
> >  int cx18_debug;
> >  
> >  module_param_array(tuner, int, &tuner_c, 0644);
> > -module_param_array(radio, bool, &radio_c, 0644);
> > +module_param_named(radio, radio_c, bool, 0644);
> >  module_param_array(cardtype, int, &cardtype_c, 0644);
> >  module_param_string(pal, pal, sizeof(pal), 0644);
> >  module_param_string(secam, secam, sizeof(secam), 0644);
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/