linux-kernel - Re: [PATCH v2 5/7] LPC32xx: clock.c: warning fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120131102658.GH2471@pengutronix.de>
Date:	Tue, 31 Jan 2012 11:26:58 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Roland Stigge <stigge@...com.de>
Cc:	bangaragiri.g@....com, srinivas.bakki@....com,
	sundarapandian.andithevar@....com, linus.walleij@...aro.org,
	linux-kernel@...r.kernel.org, kevin.wells@....com,
	grant.likely@...retlab.ca, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 5/7] LPC32xx: clock.c: warning fix

On Mon, Jan 30, 2012 at 05:02:04PM +0100, Roland Stigge wrote:
> This patch removes the debug warning on local_clk_disable() as done in Kevin
> Wells' driver update
> 
> Signed-off-by: Roland Stigge <stigge@...com.de>

Maybe this can be folded with 7/7? Otherwise

Acked-by: Wolfram Sang <w.sang@...gutronix.de>
Tested-by: Wolfram Sang <w.sang@...gutronix.de>

> 
> diff --git a/arch/arm/mach-lpc32xx/clock.c b/arch/arm/mach-lpc32xx/clock.c
> index 229bec5..01e9aba 100644
> --- a/arch/arm/mach-lpc32xx/clock.c
> +++ b/arch/arm/mach-lpc32xx/clock.c
> @@ -903,8 +903,6 @@ static inline void clk_unlock(void)
>  
>  static void local_clk_disable(struct clk *clk)
>  {
> -	WARN_ON(clk->usecount == 0);
> -
>  	/* Don't attempt to disable clock if it has no users */
>  	if (clk->usecount > 0) {
>  		clk->usecount--;

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)