linux-kernel - Re: [PATCH v6 2/3] seccomp_filters: system call filtering using BPF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 31 Jan 2012 08:20:34 -0700
From:	Will Drewry <wad@...omium.org>
To:	Eduardo Otubo <otubo@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, keescook@...omium.org,
	john.johansen@...onical.com, serge.hallyn@...onical.com,
	coreyb@...ux.vnet.ibm.com, pmoore@...hat.com, eparis@...hat.com,
	djm@...drot.org, torvalds@...ux-foundation.org,
	segoon@...nwall.com, rostedt@...dmis.org, jmorris@...ei.org,
	scarybeasts@...il.com, avi@...hat.com, penberg@...helsinki.fi,
	viro@...iv.linux.org.uk, luto@....edu, mingo@...e.hu,
	akpm@...ux-foundation.org, khilman@...com, borislav.petkov@....com,
	amwang@...hat.com, oleg@...hat.com, ak@...ux.intel.com,
	eric.dumazet@...il.com, gregkh@...e.de, dhowells@...hat.com,
	daniel.lezcano@...e.fr, linux-fsdevel@...r.kernel.org,
	linux-security-module@...r.kernel.org, olofj@...omium.org,
	mhalcrow@...gle.com, dlaor@...hat.com, corbet@....net,
	alan@...rguk.ukuu.org.uk, indan@....nu, mcgrathr@...omium.org
Subject: Re: [PATCH v6 2/3] seccomp_filters: system call filtering using BPF

On Tue, Jan 31, 2012 at 7:13 AM, Eduardo Otubo <otubo@...ux.vnet.ibm.com> wrote:
> On Sat, Jan 28, 2012 at 04:11:54PM -0600, Will Drewry wrote:
>> [This patch depends on luto@....edu's no_new_privs patch:
>>  https://lkml.org/lkml/2012/1/12/446
>> ]
>
> Will,
>
> I know you clearly pointed to use luto@....edu's first no_new_privs
> patch, but I couldn't avoid to test it with the latest (and 3rd) version
> of the patch [0]. Which defines PR_GET_NO_NEW_PRIVS as 37 as you can see
> here [1]. The compilation then would break here:
>
>     CC      kernel/sys.o
>   kernel/sys.c: In function ‘sys_prctl’:
>   kernel/sys.c:1975: error: duplicate case value
>   kernel/sys.c:1904: error: previously used here
>   make[1]: *** [kernel/sys.o] Error 1
>   make: *** [kernel] Error 2
>
> I just changed the value of PR_ATTACH_SECCOMP_FILTER to 38 and
> everything went fine. Do you see any problems on changing this value?

Should be fine -- in the next version, I won't be adding a new PR_
define at all.  Feel free to change it to whatever compiles -- the
code only uses the define name for access.  Sorry for the collision -
I posted the last rev without the latest from luto.

Cheers!
will

> Regards,
>
> [0] - https://git.kernel.org/?p=linux/kernel/git/luto/linux.git;a=heads
> [1] -
> https://git.kernel.org/?p=linux/kernel/git/luto/linux.git;a=blobdiff;f=include/linux/prctl.h;h=a6b5ac9cfe560eeb277646fbe338ae2b14c46caf;hp=7ddc7f1b480fd41318d94c0a39c8e2ff80f9c5f8;hb=7102b0e278af50d27b5d61d1be5faaba1b0a091e;hpb=acb42a3b611d7ad4cb173c3b37674b549df2ffeb
>
> --
> Eduardo Otubo
> Software Engineer
> Linux Technology Center
> IBM Systems & Technology Group
> Mobile: +55 19 8135 0885
> eotubo@...ux.vnet.ibm.com
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/