linux-kernel - Re: [PATCH] smsc95xx: add macaddr module parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120131172731.03df5704@pyramind.ukuu.org.uk>
Date:	Tue, 31 Jan 2012 17:27:31 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Danny Kukawka <danny.kukawka@...ect.de>
Cc:	netdev@...r.kernel.org, Greg Kroah-Hartman <gregkh@...e.de>,
	Steve Glendinning <steve.glendinning@...c.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Danny Kukawka <dkukawka@...e.de>
Subject: Re: [PATCH] smsc95xx: add macaddr module parameter

On Tue, 31 Jan 2012 18:20:33 +0100
Danny Kukawka <danny.kukawka@...ect.de> wrote:

> Added smsc95xx.macaddr module parameter to allow the user to
> change the MAC address on boot if there was no MAC on the EEPROM.

NAK. Please see the discussion on this and ifconfig hw for other devices.

In summary - make the device refuse to ifconfig up without a valid
address, allow it to come into existance without a valid address and then
use ifconfig.


Your patch also seems to break if there are several attached to a board.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/