linux-kernel - Re: [PATCH] smsc95xx: add macaddr module parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120131.144558.1534275761422552896.davem@davemloft.net>
Date:	Tue, 31 Jan 2012 14:45:58 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	danny.kukawka@...ect.de
Cc:	alan@...rguk.ukuu.org.uk, netdev@...r.kernel.org, gregkh@...e.de,
	steve.glendinning@...c.com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] smsc95xx: add macaddr module parameter

From: Danny Kukawka <danny.kukawka@...ect.de>
Date: Tue, 31 Jan 2012 19:17:11 +0100

> On Dienstag, 31. Januar 2012, Alan Cox wrote:
>> On Tue, 31 Jan 2012 18:20:33 +0100
>>
>> Danny Kukawka <danny.kukawka@...ect.de> wrote:
>> > Added smsc95xx.macaddr module parameter to allow the user to
>> > change the MAC address on boot if there was no MAC on the EEPROM.
>>
>> NAK. Please see the discussion on this and ifconfig hw for other devices.
>>
>> In summary - make the device refuse to ifconfig up without a valid
>> address, allow it to come into existance without a valid address and then
>> use ifconfig.
>>
>>
>> Your patch also seems to break if there are several attached to a board.
> 
> There are already other kernel driver which allow to override the (hw) MAC 
> address via a module parameter (macaddr): 

Too bad, it's bad precendence and just because we mistakenly let other
drivers do it in the past, it's not an excuse to allow you to make this
mistake too.

This patch will not be applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/