linux-kernel - Re: [PATCH] Input: evdev - fix variable initialisation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPz4a6DDwt2uEX1o3ULSESjnVqMA1gBWoFP27XCviaOXd1-fpw@mail.gmail.com>
Date:	Tue, 31 Jan 2012 13:40:42 -0800
From:	Dima Zavin <dima@...roid.com>
To:	Heiko Stübner <heiko@...ech.de>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: evdev - fix variable initialisation

ugh, thanks for fixing this.

On Tue, Jan 31, 2012 at 1:24 PM, Heiko Stübner <heiko@...ech.de> wrote:
> Commit 509f87c5f564 (evdev - do not block waiting for an event if fd
> is nonblock) created a code path were it was possible to use retval
> uninitialized.
>
> This could lead to the xorg evdev input driver getting corrupt data
> and refusing to work with log messages like
>        AUO-Pixcir touchscreen: Read error: Success
>        sg060_keys: Read error: Success
>        AUO-Pixcir touchscreen: Read error: Success
>        sg060_keys: Read error: Success
> (for drivers auo-pixcir-ts and gpio-keys).
>
> Signed-off-by: Heiko Stuebner <heiko@...ech.de>

Acked-by: Dima Zavin <dima@...roid.com>

> ---
> This is obviously meant as a fix for 3.3
>
>  drivers/input/evdev.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
> index 76457d5..afc166f 100644
> --- a/drivers/input/evdev.c
> +++ b/drivers/input/evdev.c
> @@ -386,7 +386,7 @@ static ssize_t evdev_read(struct file *file, char __user *buffer,
>        struct evdev_client *client = file->private_data;
>        struct evdev *evdev = client->evdev;
>        struct input_event event;
> -       int retval;
> +       int retval = 0;
>
>        if (count < input_event_size())
>                return -EINVAL;
> --
> 1.7.2.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/