linux-kernel - Re: [PATCH] add kernel parameter to disable module load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F2755A2.5040108@redhat.com>
Date:	Tue, 31 Jan 2012 10:44:50 +0800
From:	Dave Young <dyoung@...hat.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] add kernel parameter to disable module load

On 01/29/2012 08:51 AM, Rusty Russell wrote:

> On Sat, 28 Jan 2012 11:34:50 +0800, Dave Young <dyoung@...hat.com> wrote:
>> Sometimes we need to test a kernel of same version with code or config
>> option changes.
>>
>> We already have sysctl to disable module load, but add a kernel
>> parameter will be more convenient.
> 
> 
>> +static int __init module_load_disable(char *str)
>> +{
>> +	modules_disabled = 1;
>> +	return 1;
>> +}
>> +__setup("nomodule", module_load_disable);
> 
> You misspelled core_param here :)
> 

Hello Rusty, If use core_param I'd better to change modules_disabled
from int to bool or we must pass nomodule=1 instead of simply pass
nomodule. But I think I can firstly post the core_param patch with
current int type, then work on the transition patch for the variable
type changes, what do you think?

Another do you think we need to expose this to sysfs via core_param?
According to the sysctl code looks like we should not add sysfs
interface to allow transition from "1" to "0"

-- 
Thanks
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/