linux-kernel - Re: [PATCH] module: Remove module size limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Jan 2012 23:13:08 -0500
From:	Sasha Levin <levinsasha928@...il.com>
To:	rusty@...tcorp.com.au
Cc:	linux-kernel@...r.kernel.org, Sasha Levin <sasha.levin@...cle.com>,
	Tim Abbott <tim.abbott@...cle.com>, stable@...r.kernel.org
Subject: Re: [PATCH] module: Remove module size limit

Rusty,

I'm not sure why git forgot to add the 'From' line, but if you do merge
it please add:

From: Sasha Levin <sasha.levin@...cle.com>

Thanks!

On Mon, 2012-01-30 at 23:07 -0500, Sasha Levin wrote:
> Module size was limited to 64MB, this was legacy limitation due to vmalloc()
> which was removed a while ago.
> 
> Limiting module size to 64MB is both pointless and affects real world use
> cases.
> 
> Cc: Rusty Russell <rusty@...tcorp.com.au>
> Cc: Tim Abbott <tim.abbott@...cle.com>
> Cc: stable@...r.kernel.org
> Signed-off-by: Sasha Levin <sasha.levin@...cle.com>
> ---
>  kernel/module.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/module.c b/kernel/module.c
> index 2c93276..3d56b6f 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -2380,8 +2380,7 @@ static int copy_and_check(struct load_info *info,
>  		return -ENOEXEC;
>  
>  	/* Suck in entire file: we'll want most of it. */
> -	/* vmalloc barfs on "unusual" numbers.  Check here */
> -	if (len > 64 * 1024 * 1024 || (hdr = vmalloc(len)) == NULL)
> +	if ((hdr = vmalloc(len)) == NULL)
>  		return -ENOMEM;
>  
>  	if (copy_from_user(hdr, umod, len) != 0) {


-- 

Sasha.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/