linux-kernel - Re: [PATCH 4/4] udf: Remove unnecessary OOM messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120201112857.GB16714@quack.suse.cz>
Date:	Wed, 1 Feb 2012 12:28:57 +0100
From:	Jan Kara <jack@...e.cz>
To:	Joe Perches <joe@...ches.com>
Cc:	Jan Kara <jack@...e.cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] udf: Remove unnecessary OOM messages

On Tue 31-01-12 14:42:10, Joe Perches wrote:
> Per call site OOM messages are unnecessary.
> k.alloc and v.alloc failures use dump_stack().
  Thanks. Applied.

							Honza

> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  fs/udf/super.c |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/udf/super.c b/fs/udf/super.c
> index c09a84d..19111f9 100644
> --- a/fs/udf/super.c
> +++ b/fs/udf/super.c
> @@ -948,11 +948,8 @@ static struct udf_bitmap *udf_sb_alloc_bitmap(struct super_block *sb, u32 index)
>  	else
>  		bitmap = vzalloc(size); /* TODO: get rid of vzalloc */
>  
> -	if (bitmap == NULL) {
> -		udf_err(sb, "Unable to allocate space for bitmap and %d buffer_head pointers\n",
> -			nr_groups);
> +	if (bitmap == NULL)
>  		return NULL;
> -	}
>  
>  	bitmap->s_block_bitmap = (struct buffer_head **)(bitmap + 1);
>  	bitmap->s_nr_groups = nr_groups;
> -- 
> 1.7.8.111.gad25c.dirty
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/