linux-kernel - [patch] hwmon: (mc13xxx-adc) make name buffer larger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 1 Feb 2012 17:42:31 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Jean Delvare <khali@...ux-fr.org>
Cc:	Guenter Roeck <guenter.roeck@...csson.com>,
	lm-sensors@...sensors.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: [patch] hwmon: (mc13xxx-adc) make name buffer larger

This is doesn't change how the code works, it's just a thing to make the
static checkers happy.  We transfer a 12 character string from a 20
character buffer to a 10 character buffer using snprintf().  The static
checkers complain that that lops off the last couple characters.

The static checkers are right, but it turns out we don't care because
later on we truncate the name at the '-' character.  Oh well, let's
change it so they don't complain.

Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

diff --git a/drivers/hwmon/mc13783-adc.c b/drivers/hwmon/mc13783-adc.c
index e9a7659d..282aaf5 100644
--- a/drivers/hwmon/mc13783-adc.c
+++ b/drivers/hwmon/mc13783-adc.c
@@ -37,7 +37,7 @@
 struct mc13783_adc_priv {
 	struct mc13xxx *mc13xxx;
 	struct device *hwmon_dev;
-	char name[10];
+	char name[PLATFORM_NAME_SIZE];
 };

 static ssize_t mc13783_adc_show_name(struct device *dev, struct device_attribute
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/