linux-kernel - Re: [PATCH] mfd/ab8500: support AB9540 variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120201144925.GE17170@opensource.wolfsonmicro.com>
Date:	Wed, 1 Feb 2012 14:49:25 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Linus Walleij <linus.walleij@...ricsson.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	linux-kernel@...r.kernel.org,
	Michel Jaouen <michel.jaouen@...ricsson.com>,
	Maxime Coquelin <maxime.coquelin@...ericsson.com>,
	Alex Macro <alex.macro@...ricsson.com>
Subject: Re: [PATCH] mfd/ab8500: support AB9540 variant

On Wed, Feb 01, 2012 at 03:42:59PM +0100, Linus Walleij wrote:

> For newer ASICs we solve it by not providing platform data
> and instead fall back to reading chip revision.

Given all that it sounds like it'd be more accurate to say that for old
chips we fall back on platform data - fall back sounds like it's a
failure mode but it seems like the opposite is true.

A more idiomatic way of doing this would be to register the device with
the appropriate name and then use driver data in the i2c_device_id to
pick the appropriate variant data up - this has the added bonus of
getting you a free device tree binding.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)