linux-kernel - Re: [PATCH net-next] net: dev: Convert printks to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1328125229.18641.17.camel@joe2Laptop>
Date:	Wed, 01 Feb 2012 11:40:29 -0800
From:	Joe Perches <joe@...ches.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: dev: Convert printks to pr_<level>

On Wed, 2012-02-01 at 14:21 -0500, David Miller wrote:
> From: Joe Perches <joe@...ches.com>
> Date: Sun, 29 Jan 2012 16:20:30 -0800
> > -		pr_warning("Number of in use tx queues changed "
> > -			   "invalidating tc mappings. Priority "
> > -			   "traffic classification disabled!\n");
> > +		pr_warn(
> > +"Number of in use tx queues changed invalidating tc mappings. "
> > +"Priority traffic classification disabled!\n");
> Don't do things like this.  It is never correct to un-indent subsequent
> lines of a string like this.  And a line ending in "pr_whatever(" looks
> terrible.

I don't care much one way or another about it.
There are a few different uses in that file already.

I do try to avoid having the compiler do string
coalescing.  In this case, I thought it unlikely
that a person would grep with content from both
sentences though.

Coalesced, this format is:

"Number of in use tx queues changed invalidating tc mappings. Priority traffic classification disabled!\n"

105 chars.  That's pretty long.
Do you prefer coalesced formats in all cases?

		pr_warn("Number of in use tx queues changed invalidating tc mappings. Priority traffic classification disabled!\n");


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/