linux-kernel - Re: [PATCH] selftests: Make run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120201115403.d140742e.akpm@linux-foundation.org>
Date:	Wed, 1 Feb 2012 11:54:03 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] selftests: Make run_tests executable

On Wed, 1 Feb 2012 16:24:53 +0100
Frederic Weisbecker <fweisbec@...il.com> wrote:

> On Mon, Jan 30, 2012 at 03:51:05PM -0800, Andrew Morton wrote:
> > On Mon, 30 Jan 2012 18:04:29 +0100
> > Frederic Weisbecker <fweisbec@...il.com> wrote:
> > 
> > > Make the main script that launches the tests to
> > > become executable. Otherwise people need to launch
> > > it as an argument to a new bash instance.
> > > 
> > 
> > That's a feature ;)
> > 
> > The x bit can easily get lost on kernel scripts.  For example, if
> > someone upgrades their kernel with patch(1) and the patch adds or
> > renames the script, the x bit gets lost.
> > 
> > If we were to set the x bit for the subset of people who get their
> > scripts direct from a git repository then those people might write and
> > distribute tools which fail when used by people who have lost their x
> > bit.  I've seen this happen at least once before.
> > 
> 
> I see. Another way could be to chmod the run_test script from the Makefile.
> Would that sound clumsy?

I suggest we remove the script and make it a makefile target instead. 
"make tests" or whatever.  As a microbonus that would remove the need
to duplicate the TARGETS definition in the two scripts.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/