linux-kernel - Re: [PATCH] ARM: LPC32xx: Support for OHCI HCD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120202164114.GB3219@pengutronix.de>
Date:	Thu, 2 Feb 2012 17:41:14 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	stigge@...com.de
Cc:	bangaragiri.g@....com, srinivas.bakki@....com,
	sundarapandian.andithevar@....com, linus.walleij@...aro.org,
	linux-kernel@...r.kernel.org, kevin.wells@....com,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: LPC32xx: Support for OHCI HCD

On Wed, Feb 01, 2012 at 02:30:28PM +0100, stigge@...com.de wrote:
> This patch adds OHCI support to the LPC32xx ARM platform
> 
> Signed-off-by: Roland Stigge <stigge@...com.de>

Okay, I asked for a patch to test USB, so thanks. It did not work for me,
sadly, so there seems to be more work needed in that area.

Yet, even formally, this patch is not ready for mainline. It touches
various subsystems in one patch (arch, usb), uses too much #ifdef and
also misses important mailing lists (usb).

May I ask if you read Documentation/development-process and/or
Documentation/SubmittingPatches? If not, please do so.

I'd suggest to work in smaller steps. Get LPC32xx build again and fix
the elementary clock issues. Then, get USB to work (for example). Then,
get the network driver accepted (for example). Also consider, that those
drivers have not just been forgotten to be posted. They usually had
issues which need to be fixed before mainlining. So, one task at a time
will help to keep focused, I think.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)