lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 02 Feb 2012 11:11:59 -0800 From: Joe Perches <joe@...ches.com> To: Karsten Keil <kkeil@...ux-pingi.de> Cc: geunsik.lim@...il.com, David Miller <davem@...emloft.net>, isdn@...ux-pingi.de, lucas.demarchi@...fusion.mobi, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] Keep kernel coding style rule of hfs-s+/sp source On Thu, 2012-02-02 at 20:01 +0100, Karsten Keil wrote: > > >> This was probably there to eliminate compiler warnings or avoid the > Yes it was. [] > I think in this case a coding style violation is minor to a warning or > potencial miscompiling. > Do not misunderstand me that I do not like to make the code better and more > readable, but such small style violations should be only fixed when here is > a strong need or the driver is reworked in bigger parts and full testing > is done. I agree, but in the future (or perhaps even today) it's better to mark these odd coding style uses with macros to indicate the reason for their use. Perhaps something akin to the ACCESS_ONCE macro like #define PERFORM_ONCE(expr) \ do { \ if ((expr)) \ ; \ } while (0) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists