linux-kernel - Re: [PATCH 3/5] TTY: use tty_standard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 03 Feb 2012 00:23:36 +0100
From:	Jiri Slaby <jslaby@...e.cz>
To:	Greg KH <greg@...ah.com>
CC:	Jiri Slaby <jirislaby@...il.com>, gregkh@...e.de,
	linux-kernel@...r.kernel.org, alan@...ux.intel.com
Subject: Re: [PATCH 3/5] TTY: use tty_standard_install

On 02/03/2012 12:05 AM, Greg KH wrote:
> On Mon, Jan 30, 2012 at 09:14:30PM +0100, Jiri Slaby wrote:
>> Use the helper in the rest of the tty drivers. This is a simple
>> replacement.
> 
> It would be, if you actually built this patch, as it is, it breaks :(

Yes, I replied to this patch that I sent you some broken bastard. Also I
attached the correct version...

>> --- a/drivers/isdn/capi/capi.c
>> +++ b/drivers/isdn/capi/capi.c
>> @@ -1015,14 +1015,11 @@ capinc_tty_install(struct tty_driver *driver, struct tty_struct *tty)
>>  {
>>  	int idx = tty->index;
>>  	struct capiminor *mp = capiminor_get(idx);
>> -	int ret = tty_init_termios(tty);
>> +	int ret = tty_standard_install(tty);
> 
> This, and, all of the other calls in this patch, should be (driver, tty)
> for the function arguments, right?
> 
> That seems to fix the build for me, so I've checked it in, but please
> verify that I got it right.

It is OK.

Sorry for that.

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/