linux-kernel - Re: [PATCH 1/3 v2] pch_udc: Detecting VBUS through GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120203073247.GD24297@legolas.emea.dhcp.ti.com>
Date:	Fri, 3 Feb 2012 09:32:48 +0200
From:	Felipe Balbi <balbi@...com>
To:	Tomoya MORINAGA <tomoya.rohm@...il.com>
Cc:	Felipe Balbi <balbi@...com>, Greg Kroah-Hartman <gregkh@...e.de>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	qi.wang@...el.com, yong.y.wang@...el.com, joel.clark@...el.com,
	kok.howg.ewe@...el.com
Subject: Re: [PATCH 1/3 v2] pch_udc: Detecting VBUS through GPIO

Hi,

On Fri, Feb 03, 2012 at 04:35:26PM +0900, Tomoya MORINAGA wrote:
> Problem:
>  In USB Suspend, pch_udc handles 'disconnect'.
> 
> Root cause:
>  The current pch_udc is not monitoring VBUS.
>  When USB cable is disconnected, USB Device Controller generates
>  an interrupt of USB Suspend.
>  pch_udc cannot distinguish it is USB Suspend or disconnect.
>  Therefore, pch_udc handles 'disconnect' after an interrupt of
>  USB Suspend happend.
> 
> Solution:
>  VBUS is detected through GPIO.
>  After an interrupt produced USB Suspend, if VBUS is Low,
>  pch_udc handles 'disconnect'.
>  If VBUS is High, pch_udc handles 'suspend'.
> 
> Signed-off-by: Tomoya MORINAGA <tomoya.rohm@...il.com>

Next time, please reply to the v1 of the patch. git send-email has this
--in-reply-to option which helps with that ;-)

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)