linux-kernel - Re: [PATCH] perf, tool: Fix perf stack to non executable on x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1328262648.2157.2.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Date:	Fri, 03 Feb 2012 10:50:48 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	acme@...hat.com, a.p.zijlstra@...llo.nl, mingo@...e.hu,
	paulus@...ba.org, cjashfor@...ux.vnet.ibm.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf, tool: Fix perf stack to non executable on x86_64

Le mercredi 01 février 2012 à 13:54 +0100, Jiri Olsa a écrit :
> By adding following objects:
>   bench/mem-memset-x86-64-asm.o
>   bench/mem-memcpy-x86-64-asm.o
> the x86_64 perf binary ended up with executable stack.
> 
> The reason was that above objects are assembler sourced and
> are missing the GNU-stack note section. In such case the linker
> assumes that the final binary should not be restricted at all
> and mark the stack as RWX.
> 
> Adding section ".note.GNU-stack" definition to mentioned objects,
> with all flags disabled, thus omiting those objects from linker
> stack flags decision.
> 
> Signed-off-by: Jiri Olsa <jolsa@...hat.com>
> ---

Good catch, thanks !

Acked-by: Eric Dumazet <eric.dumazet@...il.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/