linux-kernel - Re: [PATCH 5/7] ftrace, perf: Add support to use function tracepoint in perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 03 Feb 2012 08:53:55 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Jiri Olsa <jolsa@...hat.com>, mingo@...hat.com, paulus@...ba.org,
	acme@...stprotocols.net, a.p.zijlstra@...llo.nl,
	linux-kernel@...r.kernel.org, aarapov@...hat.com
Subject: Re: [PATCH 5/7] ftrace, perf: Add support to use function
 tracepoint in perf

On Thu, 2012-02-02 at 19:14 +0100, Frederic Weisbecker wrote:

> All the above from perf_ftrace_function_call() to here should perhaps
> go to trace_function.c.

Please no. This is a perf specific call into the function tracer.
Unless it is rewritten to be a completely generic function. As with the
normal rational on "generic" vs "specific" in the kernel. When there's
only one user, then keep it "specific". When we get two or more users,
then it can be converted to be generic.

Please do not put this into trace_function.c, as the only user of it is
here.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/