| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1328282767-13158-1-git-send-email-xi.wang@gmail.com> Date: Fri, 3 Feb 2012 10:26:07 -0500 From: Xi Wang <xi.wang@...il.com> To: KONISHI Ryusuke <konishi.ryusuke@....ntt.co.jp> Cc: linux-nilfs@...r.kernel.org, linux-kernel@...r.kernel.org, Xi Wang <xi.wang@...il.com>, Haogang Chen <haogangchen@...il.com>, Andrew Morton <akpm@...ux-foundation.org> Subject: [PATCH] nilfs2: avoid overflowing segment numbers in nilfs_ioctl_clean_segments() nsegs is read from userspace. Limit its value and avoid overflowing nsegs * sizeof(__u64) in the subsequent call to memdup_user(). This patch complements 481fe17e973fb97aa3edf17c69557afe88d8334f. Signed-off-by: Xi Wang <xi.wang@...il.com> Cc: Haogang Chen <haogangchen@...il.com> Cc: Andrew Morton <akpm@...ux-foundation.org> --- fs/nilfs2/ioctl.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c index 8866496..2a70fce 100644 --- a/fs/nilfs2/ioctl.c +++ b/fs/nilfs2/ioctl.c @@ -603,6 +603,8 @@ static int nilfs_ioctl_clean_segments(struct inode *inode, struct file *filp, nsegs = argv[4].v_nmembs; if (argv[4].v_size != argsz[4]) goto out; + if (nsegs > UINT_MAX / sizeof(__u64)) + goto out; /* * argv[4] points to segment numbers this ioctl cleans. We -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists