linux-kernel - Re: [PATCH 08/15] mm: mmzone: MIGRATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <op.v830ygma3l0zgt@mpn-glaptop>
Date:	Fri, 03 Feb 2012 16:50:30 +0100
From:	"Michal Nazarewicz" <mina86@...a86.com>
To:	"Marek Szyprowski" <m.szyprowski@...sung.com>,
	"Hillf Danton" <dhillf@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-media@...r.kernel.org, linux-mm@...ck.org,
	linaro-mm-sig@...ts.linaro.org,
	"Kyungmin Park" <kyungmin.park@...sung.com>,
	"Russell King" <linux@....linux.org.uk>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@...fujitsu.com>
Subject: Re: [PATCH 08/15] mm: mmzone: MIGRATE_CMA migration type added

> On Fri, Feb 3, 2012 at 8:18 PM, Marek Szyprowski
> <m.szyprowski@...sung.com> wrote:
>> From: Michal Nazarewicz <mina86@...a86.com>
>> diff --git a/mm/compaction.c b/mm/compaction.c
>> index d5174c4..a6e7c64 100644
>> --- a/mm/compaction.c
>> +++ b/mm/compaction.c
>> @@ -45,6 +45,11 @@ static void map_pages(struct list_head *list)
>>        }
>>  }
>>
>> +static inline bool migrate_async_suitable(int migratetype)

On Fri, 03 Feb 2012 15:19:54 +0100, Hillf Danton <dhillf@...il.com> wrote:
> Just nitpick, since the helper is not directly related to what async means,
> how about migrate_suitable(int migrate_type) ?

I feel current name is better suited since it says that it's OK to scan this
block if it's an asynchronous compaction run.

>> +{
>> +       return is_migrate_cma(migratetype) || migratetype == MIGRATE_MOVABLE;
>> +}
>> +
>>  /*
>>  * Isolate free pages onto a private freelist. Caller must hold zone->lock.
>>  * If @strict is true, will abort returning 0 on any invalid PFNs or non-free
>> @@ -277,7 +282,7 @@ isolate_migratepages_range(struct zone *zone, struct compact_control *cc,
>>                 */
>>                pageblock_nr = low_pfn >> pageblock_order;
>>                if (!cc->sync && last_pageblock_nr != pageblock_nr &&
>> -                               get_pageblock_migratetype(page) != MIGRATE_MOVABLE) {
>> +                   migrate_async_suitable(get_pageblock_migratetype(page))) {
>
> Here compaction looks corrupted if CMA not enabled, Mel?

Damn, yes, this should be !migrate_async_suitable(...).  Sorry about that.

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@...gle.com>--------------ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/