linux-kernel - Re: [PATCH 05/11] mmc/host: add context parameter for DMA_SLAVE and DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120203170153.GA15891@flint.arm.linux.org.uk>
Date:	Fri, 3 Feb 2012 17:01:53 +0000
From:	Russell King <rmk@....linux.org.uk>
To:	"Bounine, Alexandre" <Alexandre.Bounine@....com>
Cc:	Ulf Hansson <ulf.hansson@...ricsson.com>, vinod.koul@...el.com,
	dan.j.williams@...el.com, linux-kernel@...r.kernel.org,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Chris Ball <cjb@...top.org>,
	Guennadi Liakhovetski <g.liakhovetski@....de>,
	Ian Molton <ian@...menth.co.uk>,
	Linus Walleij <linus.walleij@...aro.org>,
	Per FORLIN <per.forlin@...ricsson.com>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Anton Vorontsov <cbouatmailru@...il.com>,
	Shawn Guo <shawn.guo@...aro.org>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Viresh KUMAR <viresh.kumar@...com>
Subject: Re: [PATCH 05/11] mmc/host: add context parameter for DMA_SLAVE
	and DMA_CYCLIC

On Fri, Feb 03, 2012 at 08:52:07AM -0800, Bounine, Alexandre wrote:
> If these API changes will be approved I will resubmit these changes as
> one patch.

I'd like to suggest an alternative approach, if you still want to add a
void * parameter to this.

1. A patch which adds this, and convert users over to it:

static inline struct dma_async_tx_descriptor *dmaengine_prep_slave_sg(
	struct dma_chan *chan, struct scatterlist *sg, unsigned sg_len,
	enum dma_transfer_direction direction, unsigned long flags)
{
	return chan->device->device_prep_slave_sg(chan, sg, sglen, dir, flags);
}

2. Change device->device_prep_slave_sg() to have a new prototype, and
   update the above inline function to cope with the change.  This API
   change is then restricted to just the DMA engine code.

3. Introduce a new inline function to deal with rapidio slave sg
   submission.

This means all drivers which aren't capable of using the special rapidio
features get to ignore the new details about rapidio entirely.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/