linux-kernel - Re: [PATCH 06/16] cpcihp: fix debug module parameter to be bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAO8r2eeSPQnCR4KkZyrZA8LtsZY3nnsNHYynBC0Rc8N-02fihQ@mail.gmail.com>
Date:	Thu, 2 Feb 2012 19:06:52 -0500
From:	Scott Murray <scott@...teful.org>
To:	Danny Kukawka <danny.kukawka@...ect.de>
Cc:	Jesse Barnes <jbarnes@...tuousgeek.org>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/16] cpcihp: fix debug module parameter to be bool

Sorry for the delay, this looks fine.

Acked-by: Scott Murray <scott@...teful.org>

On Mon, Jan 30, 2012 at 5:00 PM, Danny Kukawka <danny.kukawka@...ect.de> wrote:
>
> Fix debug variable from module parameter to be really bool to
> fix 'warning: return from incompatible pointer type'.
>
> Signed-off-by: Danny Kukawka <danny.kukawka@...ect.de>
> ---
>  drivers/pci/hotplug/cpcihp_generic.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/pci/hotplug/cpcihp_generic.c b/drivers/pci/hotplug/cpcihp_generic.c
> index fb3f846..81af764 100644
> --- a/drivers/pci/hotplug/cpcihp_generic.c
> +++ b/drivers/pci/hotplug/cpcihp_generic.c
> @@ -62,7 +62,7 @@
>  #define warn(format, arg...) printk(KERN_WARNING "%s: " format "\n", MY_NAME , ## arg)
>
>  /* local variables */
> -static int debug;
> +static bool debug;
>  static char *bridge;
>  static u8 bridge_busnr;
>  static u8 bridge_slot;
> --
> 1.7.7.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/