linux-kernel - Re: [Patch] tty: fix a build failure on sparc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120203194608.GA23948@windriver.com>
Date:	Fri, 3 Feb 2012 14:46:09 -0500
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
CC:	<linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alan Cox <alan@...ux.intel.com>,
	Jamie Iles <jamie@...ieiles.com>,
	Stephen Warren <swarren@...dia.com>,
	<linux-serial@...r.kernel.org>
Subject: Re: [Patch] tty: fix a build failure on sparc

[Resending with updated address for Greg]

On 12-02-03 12:22 AM, Cong Wang wrote:
> On sparc, there is a build failure:
> 
> drivers/tty/serial/8250/8250.c:48:21: error: suncore.h: No such file or directory
> drivers/tty/serial/8250/8250.c:3275: error: implicit declaration of function 'sunserial_register_minors'
> drivers/tty/serial/8250/8250.c:3305: error: implicit declaration of function 'sunserial_unregister_minors'
> 
> this is due to commit 9bef3d4197379a995fa80f81950bbbf8d32e9e8b
> (serial: group all the 8250 related code together) moved these files
> into 8250/ subdirectory, but forgot to change the reference
> to drivers/tty/serial/suncore.h.

Thanks, I explicitly left sunsu out of the move but missed
that 8250 was sourcing its related header.  I did defconfig
builds, but in going back to check, I see that neither sparc
32/64 defconfig enable 8250 by default, so those builds didn't
help me much at all...  :(

Acked-by: Paul Gortmaker <paul.gortmaker@...driver.com>

> 
> Cc: Paul Gortmaker <paul.gortmaker@...driver.com>
> Cc: Greg Kroah-Hartman <gregkh@...e.de>
> Signed-off-by: WANG Cong <xiyou.wangcong@...il.com>
> 
> ---
> diff --git a/drivers/tty/serial/8250/8250.c b/drivers/tty/serial/8250/8250.c
> index 9f50c4e..9b7336f 100644
> --- a/drivers/tty/serial/8250/8250.c
> +++ b/drivers/tty/serial/8250/8250.c
> @@ -45,7 +45,7 @@
>  #include "8250.h"
>  
>  #ifdef CONFIG_SPARC
> -#include "suncore.h"
> +#include "../suncore.h"
>  #endif
>  
>  /*
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/