linux-kernel - Re: cgroup_release_agent() with call_usermodehelper() with UMH_WAIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 4 Feb 2012 07:16:51 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Oleg Nesterov <oleg@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Paul Menage <paul@...lmenage.org>,
	linux-kernel@...r.kernel.org,
	Sebastian Ott <sebott@...ux.vnet.ibm.com>
Subject: Re: cgroup_release_agent() with call_usermodehelper() with
 UMH_WAIT_EXEC may crash

On Sat, Feb 4, 2012 at 2:03 AM, Heiko Carstens
<heiko.carstens@...ibm.com> wrote:
>
> Something like the patch below? Still boots...

Yes, except that if we touch the comm copying code, let's do what Oleg
suggested and make it a helper function to create the "comm[]" data
array instead of open-coding it and adding new random local variables
to prepare_binprm().

But looks good otherwise. I'm a *bit* nervous that some
prepare_binprm() caller hasn't set up bprm->filename that early yet,
though. It seems like we expect that to be set up by the caller, which
seems a bit odd, actually.

                    Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/