linux-kernel - Re: [PATCH Updated] PM/Freezer: Thaw only kernel threads if freezing of kernel threads fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201202042327.10045.rjw@sisk.pl>
Date:	Sat, 4 Feb 2012 23:27:09 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>
Cc:	Tejun Heo <tj@...nel.org>, pavel@....cz, len.brown@...el.com,
	linux-pm@...r.kernel.org,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	Nigel Cunningham <nigel@...onice.net>
Subject: Re: [PATCH Updated] PM/Freezer: Thaw only kernel threads if freezing of kernel threads fails

On Saturday, February 04, 2012, Srivatsa S. Bhat wrote:
> On 02/02/2012 04:29 AM, Srivatsa S. Bhat wrote:
> 
> > 
> > From: Srivatsa S. Bhat <srivatsa.bhat@...ux.vnet.ibm.com>
> > Subject: [PATCH] PM/Freezer: Thaw only kernel threads if freezing of kernel threads fails
> > 
> > If freezing of kernel threads fails, we are expected to automatically thaw
> > tasks in the error recovery path. However, at times, we encounter situations
> > in which we would like the automatic error recovery path to thaw only the
> > kernel threads, because we want to be able to do some more cleanup before
> > we thaw userspace. Something like:
> > 
> > error = freeze_kernel_threads();
> > if (error) {
> > 	/* Do some cleanup */
> > 
> > 	/* Only then thaw userspace tasks*/
> > 	thaw_processes();
> > }
> > 
> > An example of such a situation is where we freeze/thaw filesystems during
> > suspend/hibernation. There, if freezing of kernel threads fails, we would
> > like to thaw the frozen filesystems before thawing the userspace tasks.
> > 
> > So, modify freeze_kernel_threads() to thaw only kernel threads in case of
> > freezing failure. And change suspend_freeze_processes() accordingly.
> > (At the same time, let us also get rid of the rather cryptic usage of the
> > conditional operator (:?) in that function.)
> > 
> > Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@...ux.vnet.ibm.com>
> > Acked-by: Tejun Heo <tj@...nel.org>
> > ---
> 
> 
> Hi Rafael,
> 
> I have reworked the changelog of this patch to indicate that this fixes a
> regression. Here is the updated patch:

Well, I've already fixed that up in my tree, but thanks anyway. :-)

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/