linux-kernel - Re: fsl-diu: enable_lcdc() takes a pointer, not struct...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F2E9C50.3050500@freescale.com>
Date:	Sun, 5 Feb 2012 15:12:18 +0000
From:	Tabi Timur-B04825 <B04825@...escale.com>
To:	Al Viro <viro@...IV.linux.org.uk>
CC:	Tabi Timur-B04825 <B04825@...escale.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"mikey@...ling.org" <mikey@...ling.org>,
	"FlorianSchandinat@....de" <FlorianSchandinat@....de>,
	"linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>
Subject: Re: fsl-diu: enable_lcdc() takes a pointer, not struct...

Al Viro wrote:
> A couple of places missed in commit ddd3d905436b572ebadc09dcf2d12ca5b37020a0...
>
> Signed-off-by: Al Viro<viro@...iv.linux.org.uk>

This is already fixed in fbdev, although I can't find the patch in the 
archives (http://marc.info/?l=linux-fbdev&r=3&b=201201&w=2).

>
> diff --git a/drivers/video/fsl-diu-fb.c b/drivers/video/fsl-diu-fb.c
> index acf292b..629ae00 100644
> --- a/drivers/video/fsl-diu-fb.c
> +++ b/drivers/video/fsl-diu-fb.c
> @@ -1432,7 +1432,7 @@ static int fsl_diu_suspend(struct platform_device *ofdev, pm_message_t state)
>   	struct fsl_diu_data *data;
>
>   	data = dev_get_drvdata(&ofdev->dev);
> -	disable_lcdc(data->fsl_diu_info[0]);
> +	disable_lcdc(&data->fsl_diu_info[0]);
>
>   	return 0;
>   }
> @@ -1442,7 +1442,7 @@ static int fsl_diu_resume(struct platform_device *ofdev)
>   	struct fsl_diu_data *data;
>
>   	data = dev_get_drvdata(&ofdev->dev);
> -	enable_lcdc(data->fsl_diu_info[0]);
> +	enable_lcdc(&data->fsl_diu_info[0]);
>
>   	return 0;
>   }
>


-- 
Timur Tabi
Linux kernel developer at Freescale
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/