linux-kernel - Re: [PATCH 1/3] apple_bl: Convert printks to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F2F0F61.7070900@gmail.com>
Date:	Mon, 06 Feb 2012 10:23:13 +1100
From:	Ryan Mallon <rmallon@...il.com>
To:	Seth Forshee <seth.forshee@...onical.com>
CC:	linux-kernel@...r.kernel.org, Richard Purdie <rpurdie@...ys.net>,
	Matthew Garrett <mjg@...hat.com>
Subject: Re: [PATCH 1/3] apple_bl: Convert printks to pr_<level>

On 04/02/12 07:28, Seth Forshee wrote:

> Signed-off-by: Seth Forshee <seth.forshee@...onical.com>
> ---
>  drivers/video/backlight/apple_bl.c |   29 ++++++++---------------------
>  1 files changed, 8 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/video/backlight/apple_bl.c b/drivers/video/backlight/apple_bl.c
> index be98d15..66d5bec 100644
> --- a/drivers/video/backlight/apple_bl.c
> +++ b/drivers/video/backlight/apple_bl.c
> @@ -16,6 +16,8 @@
>   *  get at the firmware code in order to figure out what it's actually doing.
>   */
>  
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
>  #include <linux/module.h>
>  #include <linux/kernel.h>
>  #include <linux/init.h>
> @@ -38,13 +40,6 @@ struct hw_data {
>  
>  static const struct hw_data *hw_data;
>  
> -#define DRIVER "apple_backlight: "
> -
> -/* Module parameters. */
> -static int debug;
> -module_param_named(debug, debug, int, 0644);
> -MODULE_PARM_DESC(debug, "Set to one to enable debugging messages.");


Removal of this module parameter is not noted in the changelog.

> -
>  /*
>   * Implementation for machines with Intel chipset.
>   */
> @@ -58,9 +53,7 @@ static int intel_chipset_send_intensity(struct backlight_device *bd)
>  {
>  	int intensity = bd->props.brightness;
>  
> -	if (debug)
> -		printk(KERN_DEBUG DRIVER "setting brightness to %d\n",
> -		       intensity);
> +	pr_debug("setting brightness to %d\n", intensity);


As Joe points out, this no longer has the same behaviour as it did
previously. The pr_debug will only show up if you have DEBUG defined.
Again, this should probably be mentioned in the changelog.

~Ryan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/