linux-kernel - Re: [PATCH] acer-wmi: support for P key on TM8372

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <4F3041500200002300007E56@novprvlin0050.provo.novell.com>
Date:	Mon, 06 Feb 2012 03:08:32 -0700
From:	"Joey Lee" <jlee@...e.com>
To:	<merlin.schumacher@...il.com>
Cc:	<ike.pan@...onical.com>, <mjg@...hat.com>,
	"Joey Lee" <JLee@...e.com>, <linux-kernel@...r.kernel.org>,
	<platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH] acer-wmi: support for P key on TM8372

Hi Merlin, 

於 四，2012-01-26 於 12:53 +0100，Merlin Schumacher 提到：
> Am 26.01.2012 03:28, schrieb joeyli:
> > Hi Ike,
> >
> > 於 二，2012-01-24 於 04:35 +0800，Ike Panhc 提到：
> >> From: Merlin Schumacher<merlin.schumacher@...il.com>
> >>
> >> BugLink: http://launchpad.net/bugs/865807
> >>
> >> There is no entry for P key on TM8372, so when P key is pressed, only
> >> "acer_wmi: Unknown key number - 0x29" in dmesg.
> >>
> >> Signed-off-by: Merlin Schumacher<merlin.schumacher@...il.com>
> >> Signed-off-by: Ike Panhc<ike.pan@...onical.com>
> >
> > Reviewed-by: Lee, Chun-Yi<jlee@...e.com>
> >
> >> ---
> >>   drivers/platform/x86/acer-wmi.c |    1 +
> >>   1 files changed, 1 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> >> index b848277..d48262c 100644
> >> --- a/drivers/platform/x86/acer-wmi.c
> >> +++ b/drivers/platform/x86/acer-wmi.c
> >> @@ -105,6 +105,7 @@ static const struct key_entry acer_wmi_keymap[] = {
> >>   	{KE_KEY, 0x22, {KEY_PROG2} },    /* Arcade */
> >>   	{KE_KEY, 0x23, {KEY_PROG3} },    /* P_Key */
> >>   	{KE_KEY, 0x24, {KEY_PROG4} },    /* Social networking_Key */
> >> +	{KE_KEY, 0x29, {KEY_PROG3} },    /* P_Key for TM8372 */
> >>   	{KE_IGNORE, 0x41, {KEY_MUTE} },
> >>   	{KE_IGNORE, 0x42, {KEY_PREVIOUSSONG} },
> >>   	{KE_IGNORE, 0x43, {KEY_NEXTSONG} },
> >
> > This patch has no problem, but could you please provide the dmidecode
> > result to me for reference?
> >
> >
> > Thanks a lot!
> > Joey Lee
> >
> 
> Hi,
> 
> attached you'll find the output of dmidecode on the TM8372. If you need 
> anything else, let me know.
> 
> You're welcome
> 
> Merlin Schumacher
> 
> 

Thanks for your dmidecode log of TM8372, I can keep it for regression
test after add new functions.


Thanks a lot!
Joey Lee


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/