linux-kernel - Re: [PATCH 05/15] mm: compaction: export some of the functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJd=RBAsRA-yggVSmijJPTLM2kKiLKWrTS9RjtESgPDc3pYTug@mail.gmail.com>
Date:	Mon, 6 Feb 2012 20:46:51 +0800
From:	Hillf Danton <dhillf@...il.com>
To:	Michal Nazarewicz <mina86@...a86.com>
Cc:	Marek Szyprowski <m.szyprowski@...sung.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-media@...r.kernel.org, linux-mm@...ck.org,
	linaro-mm-sig@...ts.linaro.org,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Russell King <linux@....linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Subject: Re: [PATCH 05/15] mm: compaction: export some of the functions

2012/2/5 Michal Nazarewicz <mina86@...a86.com>:
>> On Fri, Feb 3, 2012 at 8:18 PM, Marek Szyprowski
>> <m.szyprowski@...sung.com> wrote:
>>>
>>> From: Michal Nazarewicz <mina86@...a86.com>
>>>
>>> This commit exports some of the functions from compaction.c file
>>> outside of it adding their declaration into internal.h header
>>> file so that other mm related code can use them.
>>>
>>> This forced compaction.c to always be compiled (as opposed to being
>>> compiled only if CONFIG_COMPACTION is defined) but as to avoid
>>> introducing code that user did not ask for, part of the compaction.c
>>> is now wrapped in on #ifdef.
>
>
> On Sun, 05 Feb 2012 08:40:08 +0100, Hillf Danton <dhillf@...il.com> wrote:
>>
>> What if both compaction and CMA are not enabled?
>
>
> What about it?  If both are enabled, both will be compiled and usable.
>

Better if enforced compilation of compaction is addressed in separate
patch in the patchset, according to the rule that one patch is delivered
with one issue concerned.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/