linux-kernel - Re: [patch 20/35] leds: route kbd LEDs through the generic LEDs layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120206141923.GE25434@elf.ucw.cz>
Date:	Mon, 6 Feb 2012 15:19:23 +0100
From:	Pavel Machek <pavel@....cz>
To:	Samuel Thibault <samuel.thibault@...-lyon.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	akpm@...ux-foundation.org, jslaby@...e.cz, rpurdie@...ys.net,
	linux-kernel@...r.kernel.org, Evan Broder <evan@...oder.net>,
	Arnaud Patard <arnaud.patard@...-net.org>
Subject: Re: [patch 20/35] leds: route kbd LEDs through the generic LEDs
 layer

On Mon 2011-11-14 05:06:13, Samuel Thibault wrote:
> Dmitry Torokhov, le Wed 12 Jan 2011 10:27:02 -0800, a écrit :
> > > --- a/drivers/char/Kconfig
> > > +++ b/drivers/char/Kconfig
> > > @@ -8,6 +8,7 @@ config VT
> > >  	bool "Virtual terminal" if EMBEDDED
> > >  	depends on !S390
> > >  	select INPUT
> > > +	select LEDS_INPUT
> > 
> > This will not work as LEDS_INPUT is itself depends and selects other
> > symbols and "select" statement does not propagate dependencies.
> > 
> > Anyway, I was looking at the patch this way and that and I convinced
> > myself that while input should be integrated with LED subsystem doing it
> > via an input handler is not the right way. Input handler is, by it's
> > nature, an optional operation or an interface that exists to transform
> > the input core data stream into some other form. Here OTOH we have a
> > piece of hardware that we want to manage. I think the proper conversion
> > would involve attaching led_classdev structures directly to input_dev
> > objects and controlling them at the core level.
> 
> Here is (at last!) an updated & tested patch. It actually makes things
> simpler, which is a good sign :)
> 
> I however don't know how to fix the issue about VT selecting
> INPUT_LEDS.

Any news about this one? Having keyboard leds in the common framework
seems very welcome to me.	
								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/