linux-kernel - Re: [PATCH v5 2/5] netdev: ethernet dev_alloc_skb to netdev_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+Dx6HbHcU_Y5PSCisiRJxoKLjk_TKOef2BHHoRYGrP0Jc8oUg@mail.gmail.com>
Date:	Mon, 6 Feb 2012 23:10:30 +0530
From:	"Pradeep A. Dalvi" <netdev@...deepdalvi.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/5] netdev: ethernet dev_alloc_skb to netdev_alloc_skb

On Mon, Feb 6, 2012 at 10:19 PM, David Miller <davem@...emloft.net> wrote:
> From: "Pradeep A. Dalvi" <netdev@...deepdalvi.com>
> Date: Sun,  5 Feb 2012 18:20:10 +0530
>
>> From: Pradeep A Dalvi <netdev@...deepdalvi.com>
>>
>> Replaced deprecating dev_alloc_skb with netdev_alloc_skb in drivers/net/ethernet
>>   - Removed extra skb->dev = dev after netdev_alloc_skb
>>
>> Signed-off-by: Pradeep A Dalvi <netdev@...deepdalvi.com>
>
> Applied, but again I had to fix things:
>
>> -    p = dev_alloc_skb(IEEE802_3_SZ + DE4X5_ALIGN + 2);
>> +     p = netdev_alloc_skb(dev, IEEE802_3_SZ + DE4X5_ALIGN + 2);
>  ...
>> -    p = dev_alloc_skb(len + 2);
>> +     p = netdev_alloc_skb(dev, len + 2);
>
> Leave existing indentation alone.
>
>> -             skb = dev_alloc_skb(ugeth->ug_info->uf_info.max_rx_buf_length +
>> -                                 UCC_GETH_RX_DATA_BUF_ALIGNMENT);
>> +             skb = netdev_alloc_skb(ugeth->ndev,
>> +                             ugeth->ug_info->uf_info.max_rx_buf_length +
>> +                             UCC_GETH_RX_DATA_BUF_ALIGNMENT);
>
> Line up subsequent lines of a multiline series of function arguments
> properly, each should start at the first column after the function calls
> openning parenthesis.

Thanks a lot again! And would remember about these too.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/