linux-kernel - Re: [PATCH 3/5] ACPI: EC: Add a limited number of repeats after false EC interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120206180104.GO11715@one.firstfloor.org>
Date:	Mon, 6 Feb 2012 19:01:04 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	Andi Kleen <andi@...stfloor.org>, lenb@...nel.org,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 3/5] ACPI: EC: Add a limited number of repeats after false EC interrupts

> Our EC code is, at this point, a layer of hacks piled on top of other 
> hacks. We have various patches that fix some machines and break others 
> and a lack of a detailed description of what the driver actually does 
> and where it deviates from the specification (and why).

The moving to an interrupt thread will enable a lot of cleanups
in fact. A lot of the existing code could be simplified now that
you can sleep. A lot of the nasty code was simply a workaround
for that.

I don't have plans to work on this however, since my laptop
works now (sorry). But I believe the patchkit is a good base
for further cleanups.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/