linux-kernel - Re: [PATCH 5/7] ftrace, perf: Add support to use function tracepoint in perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1328556916.2200.29.camel@gandalf.stny.rr.com>
Date:	Mon, 06 Feb 2012 14:35:16 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Jiri Olsa <jolsa@...hat.com>, mingo@...hat.com, paulus@...ba.org,
	acme@...stprotocols.net, a.p.zijlstra@...llo.nl,
	linux-kernel@...r.kernel.org, aarapov@...hat.com
Subject: Re: [PATCH 5/7] ftrace, perf: Add support to use function
 tracepoint in perf

On Sat, 2012-02-04 at 14:21 +0100, Frederic Weisbecker wrote:
>   struct ftrace_event_call __used event_##call = {			\
> > @@ -170,4 +179,9 @@ struct ftrace_event_call __used event_##call = {			\
> >  struct ftrace_event_call __used						\
> >  __attribute__((section("_ftrace_events"))) *__event_##call = &event_##call;
> >  
> > +#undef FTRACE_ENTRY
> > +#define FTRACE_ENTRY(call, struct_name, etype, tstruct, print)		\
> > +	FTRACE_ENTRY_REG(call, struct_name, etype,			\
> > +			 PARAMS(tstruct), PARAMS(print), NULL)
> > +
> >  #include "trace_entries.h"
> 
> 
> Yeah looks good. I wouldn't mind having only FTRACE_ENTRY() with one
> more parameter but I'm fine with the two macros as well.

I prefer the two macros. It's cleaner.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/