lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 6 Feb 2012 20:59:25 +0100
From:	Stephane Eranian <eranian@...gle.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, acme@...hat.com,
	robert.richter@....com, ming.m.lin@...el.com, andi@...stfloor.org,
	asharma@...com, ravitillo@....gov, vweaver1@...s.utk.edu,
	khandual@...ux.vnet.ibm.com, dsahern@...il.com
Subject: Re: [PATCH v5 09/18] perf: disable PERF_SAMPLE_BRANCH_* when not supported

On Mon, Feb 6, 2012 at 8:23 PM, Peter Zijlstra <peterz@...radead.org> wrote:
> On Thu, 2012-02-02 at 13:54 +0100, Stephane Eranian wrote:
>> @@ -539,6 +539,10 @@ static int armpmu_event_init(struct perf_event *event)
>>         int err = 0;
>>         atomic_t *active_events = &armpmu->active_events;
>>
>> +       /* does not support taken branch sampling */
>> +       if (has_branch_smpl(event))
>> +               return -EOPNOTSUPP;
>> +
>>         if (armpmu->map_event(event) == -ENOENT)
>
> I'll make that has_branch_stack(), ok? :-)
>
Supposedly, I fixed that in v5. Is it not there?
If not, then something went wrong but go ahead, that's the right fix anyway.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ