linux-kernel - RE: [PATCH] xen/tmem: cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4F2F998202000078000714CD@nat28.tlf.novell.com>
Date:	Mon, 06 Feb 2012 08:12:34 +0000
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"Dan Magenheimer" <dan.magenheimer@...cle.com>
Cc:	"Jeremy Fitzhardinge" <jeremy@...p.org>,
	<xen-devel@...ts.xensource.com>,
	"Konrad Wilk" <konrad.wilk@...cle.com>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] xen/tmem: cleanup

>>> On 04.02.12 at 17:42, Dan Magenheimer <dan.magenheimer@...cle.com> wrote:
>>  From: Jan Beulich [mailto:JBeulich@...e.com]
>> Subject: [PATCH] xen/tmem: cleanup
>> 
>> Use 'bool' for boolean variables. Do proper section placement.
>> Eliminate an unnecessary export.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@...e.com>
>> Cc: Dan Magenheimer <dan.magenheimer@...cle.com>
>> 
>> -int tmem_enabled __read_mostly;
>> -EXPORT_SYMBOL(tmem_enabled);
>> +bool __read_mostly tmem_enabled = false;
> 
> tmem_enabled is used in xen/drivers/xen-selfballoon.c

Which can't be built as a module, and hence the symbol doesn't need
exporting. This patch (of course, I'm tempted to say) survived build
testing.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/