linux-kernel - Re: [PATCH] sched: move CONFIG_IRQ_TIME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120207082907.GB12821@elte.hu>
Date:	Tue, 7 Feb 2012 09:29:07 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Dmitry Antipov <dmitry.antipov@...aro.org>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org,
	linaro-dev@...ts.linaro.org, patches@...aro.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Venkatesh Pallipadi <venki@...gle.com>
Subject: Re: [PATCH] sched: move CONFIG_IRQ_TIME_ACCOUNTING to common code


* Dmitry Antipov <dmitry.antipov@...aro.org> wrote:

> Since CONFIG_IRQ_TIME_ACCOUNTING is architecture-agnostic, 
> move it from x86 area to common code.
> 
> Signed-off-by: Dmitry Antipov <dmitry.antipov@...aro.org>
> ---
>  arch/x86/Kconfig  |   11 -----------
>  lib/Kconfig.debug |   11 +++++++++++
>  2 files changed, 11 insertions(+), 11 deletions(-)

That's not enough, right now on x86 this code needs special 
architecture glue, see how the noirqtime flag is used to call 
into enable_sched_clock_irqtime() after TSC init.

So if you apply your patch and boot CONFIG_IRQ_TIME_ACCOUNTING=y 
on say an ARM system, nothing will be done, because 
sched_clock_irqtime is always zero.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/