linux-kernel - RE: [PATCH RFC] leds: lm3530: Fix setting pltfm->als

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B567DBAB974C0544994013492B949F8E3812ED4697@EXMAIL03.scwf.nsc.com>
Date:	Tue, 7 Feb 2012 02:06:33 -0800
From:	"Kim, Milo" <Milo.Kim@...com>
To:	"Axel Lin" <axel.lin@...il.com>
cc:	"Shreshtha Kumar Sahu" <shreshthakumar.sahu@...ricsson.com>,
	"Richard Purdie" <rpurdie@...ys.net>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH RFC] leds: lm3530: Fix setting pltfm->als_vmax


> -----Original Message-----
> From: Axel Lin [mailto:axel.lin@...il.com]
> Sent: Tuesday, February 07, 2012 3:23 PM
> To: linux-kernel@...r.kernel.org
> Cc: Shreshtha Kumar Sahu; Kim, Milo; Richard Purdie; Andrew Morton
> Subject: [PATCH RFC] leds: lm3530: Fix setting pltfm->als_vmax
> 
> In current code, pltfm->als_vmin is set to LM3530_ALS_WINDOW_mV and
> pltfm->als_vmax is 0. This looks does not make sense.
> I think what we want here is setting pltfm->als_vmax to
> LM3530_ALS_WINDOW_mV.
> 
> Both als_vmin and als_vmax local variables will be set to pltfm-
> >als_vmin and
> pltfm->als_vmax by a few lines latter.
> Thus also remove a redundant assignment for als_vmin and als_vmax in
> this patch.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

This patch makes sense and fixes wrong range of the ALS input voltage.
It works well on the real board.
Thanks.

Acked-and-tested-by: Milo(Woogyom) Kim <milo.kim@...com>

BTW, I'd suggest that 'pltfm' is replaced with 'pdata' if below patch has been updated.
[PATCH v4 5/5] leds-lm3530: replace pltfm with pdata.

Best Regards,
Milo -