linux-kernel - Re: [PATCH 90/91] block: fail SCSI passthrough ioctls on partition devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120207102104.GA27069@1wt.eu>
Date:	Tue, 7 Feb 2012 11:21:04 +0100
From:	Willy Tarreau <w@....eu>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	linux-scsi@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
	James Bottomley <JBottomley@...allels.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ben Hutchings <ben@...adent.org.uk>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 90/91] block: fail SCSI passthrough ioctls on partition devices

Hi Paolo,

On Tue, Feb 07, 2012 at 11:03:03AM +0100, Paolo Bonzini wrote:
> On 02/05/2012 11:53 PM, Willy Tarreau wrote:
> >Thanks for this report, I missed this patch. I thought the reason for the 
> >lack
> >of scsi_cmd_blk_ioctl() it was one of the differences between 2.6.27 and 
> >2.6.32,
> >so I have adapted the callers I identified to perform the same test as 
> >what's
> >in scsi_cmd_blk_ioctl().
> 
> There were other callers in patch 1/3, most notably virtio-blk, that are 
> not in your patch.

Yes it was, just like ub, sd and ide-floppy. In fact backport this whole patch
was the trickiest task as I had to review each caller one after the other, and
I'm quite confident the result is fine. But I prefer to redo it from scratch
with your original patch that I missed, as it will wipe any doubts and make
further maintenance easier.

Thanks,
Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/