linux-kernel - Re: [PATCH BUGFIX] mm: fix find_get_page() for shmem exceptional entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F31003E.2090901@openvz.org>
Date:	Tue, 07 Feb 2012 14:43:10 +0400
From:	Konstantin Khlebnikov <khlebnikov@...nvz.org>
To:	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Hugh Dickins <hughd@...gle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH BUGFIX] mm: fix find_get_page() for shmem exceptional
 entries

Bug was added in commit v3.0-7291-g8079b1c (mm: clarify the radix_tree exceptional cases)
So, v3.1 and v3.2 affected.

Konstantin Khlebnikov wrote:
> It should return NULL, otherwise the caller will be very surprised.
>
> Signed-off-by: Konstantin Khlebnikov<khlebnikov@...nvz.org>
> ---
>   mm/filemap.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/mm/filemap.c b/mm/filemap.c
> index 518223b..ca98cb5 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -693,6 +693,7 @@ repeat:
>   			 * here as an exceptional entry: so return it without
>   			 * attempting to raise page count.
>   			 */
> +			page = NULL;
>   			goto out;
>   		}
>   		if (!page_cache_get_speculative(page))
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/