linux-kernel - Re: Pe: [PATCH v5 1/3] virtio-scsi: first version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F310A4F.6060602@redhat.com>
Date:	Tue, 07 Feb 2012 12:26:07 +0100
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
CC:	Christian Hoff <christian.hoff@...ibm.com>,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	rusty@...tcorp.com.au, kvm@...r.kernel.org
Subject: Re: Pe: [PATCH v5 1/3] virtio-scsi: first version

On 02/07/2012 12:10 PM, Michael S. Tsirkin wrote:
>>> Also, lun[1] = sc->device->id means that only 255 SCSI target IDs will be
>>> >  >supported. Think about bigger usage scenarios, such as FCP networks with
>>> >  >several hundred HBAs in the net. If you want to have the target ID<->HBA
>>> >  >mapping the same as on the guest as on the host, then 255 virtual target
>>> >  >IDs could be a limit.
>> >
>> >  I think you would hit other scalability limitations well before
>> >  that.  I plan to give each target its own MSI-X interrupt, but there
>> >  is no infinite supplies of those either.
> virtio-pci generally lets guests share MSI-X vectors between queues,
> why not allow this here?

Yes, of course.  However, with dozens of queues, many of them will share 
the same vector and all of them will be examined when you get the 
interrupt.  Even if you find the right balance between sharing (because 
you have to) and separating (because of scalability), I wouldn't be 
surprised if more than 255 targets do not work too well.

Anyway multiqueue is not even in this patchset, so there's more work to 
do before we can worry. :)

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/