linux-kernel - Re: [PATCH 06/07] RTC: RTC driver for DA9052/53 PMIC v1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1328617502.30549.91.camel@dhruva>
Date:	Tue, 7 Feb 2012 17:55:02 +0530
From:	Ashish Jangam <ashish.jangam@...tcummins.com>
To:	<akpm@...ux-foundation.org>
CC:	<linux-kernel@...r.kernel.org>, <sameo@...ux.intel.com>,
	<p_gortmaker@...oo.com>, <dchen@...semi.com>
Subject: Re: [PATCH 06/07] RTC: RTC driver for DA9052/53 PMIC v1

On Tue, 2012-02-07 at 17:51 +0530, Ashish Jangam wrote:
> I assume that this patch is mergeable without any of the other six
> patches in this series.  It compiles OK...
yes
> 
> > +{
> > +	int ret;
> > +	uint8_t v[5] = {0, 0, 0, 0, 0};
> 
> These initalised local arrays are expensive.  The below patch reduces
> the module's text size by over 100 bytes.
> 
> The arrays whcih are passed to da9052_group_write() surely didn't need
> initalisation, and I trust that's also the case with the arrays which
> are passed to da9052_group_read()?
Correct, they can be passed without initialisation.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/