linux-kernel - Re: [PATCH v5 11/18] perf: add code to support PERF_SAMPLE_BRANCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120207152144.GN6367@infradead.org>
Date:	Tue, 7 Feb 2012 13:21:44 -0200
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Stephane Eranian <eranian@...gle.com>
Cc:	linux-kernel@...r.kernel.org, peterz@...radead.org, mingo@...e.hu,
	robert.richter@....com, ming.m.lin@...el.com, andi@...stfloor.org,
	asharma@...com, ravitillo@....gov, vweaver1@...s.utk.edu,
	khandual@...ux.vnet.ibm.com, dsahern@...il.com
Subject: Re: [PATCH v5 11/18] perf: add code to support
	PERF_SAMPLE_BRANCH_STACK

Em Tue, Feb 07, 2012 at 03:11:56PM +0100, Stephane Eranian escreveu:
> On Mon, Feb 6, 2012 at 7:06 PM, Arnaldo Carvalho de Melo <acme@...hat.com> wrote:
> >> +++ b/tools/perf/util/annotate.c
> >> @@ -64,7 +64,7 @@ int symbol__inc_addr_samples(struct symbol *sym, struct map *map,

> >>       pr_debug3("%s: addr=%#" PRIx64 "\n", __func__, map->unmap_ip(map, addr));

> >> -     if (addr >= sym->end)
> >> +     if (addr >= sym->end || addr < sym->start)

> > This is not related to this, would be better to come in a separate patch
> > with a proper explanation.

> You mean in this patchset or separately?

Either way it would be standalone, I'd pick it, but please write a
commit message explaining why it is needed.

Multiple people submitted this already but without a good commit message
which I think may be papering over a bug.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/