linux-kernel - Re: [PATCH] kbuild: Fix link to headers in 'make deb-pkg'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120207163716.GA12704@decadent.org.uk>
Date:	Tue, 7 Feb 2012 16:37:16 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Michal Marek <mmarek@...e.cz>, Joerg Roedel <joerg.roedel@....com>,
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	debian-kernel@...ts.debian.org
Subject: Re: [PATCH] kbuild: Fix link to headers in 'make deb-pkg'

On Sat, Feb 04, 2012 at 03:34:49PM +0100, maximilian attems wrote:
> adding bwh + debian-kernel
> 
> On Mon, 23 Jan 2012, Michal Marek wrote:
> 
> > (adding max to CC)
> > 
> > On 23.1.2012 12:40, Joerg Roedel wrote:
> > > The Link to the kernel header files in the debian packages
> > > point to the original build directory. This is a bad choice
> > > if the packages were installed on a different machine. Fix
> > > this in by manually re-creating the link in the builddeb
> > > script.

Right, but:

[...]
> > > @@ -121,10 +122,14 @@ fi
> > >  
> > >  if grep -q '^CONFIG_MODULES=y' .config ; then
> > >  	INSTALL_MOD_PATH="$tmpdir" make KBUILD_SRC= modules_install
> > > -	if [ "$ARCH" = "um" ] ; then
> > > -		mv "$tmpdir/lib/modules/$version"/* "$tmpdir/usr/lib/uml/modules/$version/"
> > > -		rmdir "$tmpdir/lib/modules/$version"
> > > -	fi
> > > +fi
> > > +
> > > +# Make sure link to the headers is correct
> > > +ln -snf "/usr/src/$kernel_headers_packagename" "$tmpdir/lib/modules/$version/build"
[...]

This should be removed from the kernel image package and created
in the kernel headers package instead, otherwise it's potentially a
broken link.

Ben.

-- 
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
                                                              - Albert Camus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/