linux-kernel - Re: [PATCH 02/91] slub: fix panic with DISCONTIGMEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120207061357.GA26009@1wt.eu>
Date:	Tue, 7 Feb 2012 07:13:57 +0100
From:	Willy Tarreau <w@....eu>
To:	David Rientjes <rientjes@...gle.com>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Pekka Enberg <penberg@...nel.org>,
	James Bottomley <James.Bottomley@...e.de>,
	Greg KH <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 02/91] slub: fix panic with DISCONTIGMEM

On Mon, Feb 06, 2012 at 01:58:56PM -0800, David Rientjes wrote:
> On Sun, 5 Feb 2012, Willy Tarreau wrote:
> 
> > commit 4a5fa3590f09999f6db41bc386bce40848fa9f63 upstream.
> > 
> > Slub makes assumptions about page_to_nid() which are violated by
> > DISCONTIGMEM and !NUMA.  This violation results in a panic because
> > page_to_nid() can be non-zero for pages in the discontiguous ranges and
> > this leads to a null return by get_node().  The assertion by the
> > maintainer is that DISCONTIGMEM should only be allowed when NUMA is also
> > defined.  However, at least six architectures: alpha, ia64, m32r, m68k,
> > mips, parisc violate this.  The panic is a regression against slab, so
> > just mark slub broken in the problem configuration to prevent users
> > reporting these panics.
> > 
> > Acked-by: David Rientjes <rientjes@...gle.com>
> > Acked-by: Pekka Enberg <penberg@...nel.org>
> > Signed-off-by: James Bottomley <James.Bottomley@...e.de>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> 
> The problem that this patch initially addressed is fixed by the next patch 
> in your series, "set memory ranges in N_NORMAL_MEMORY when onlined", so I 
> don't think this one should be merged.

Perfect, I'm dropping it then.

Thank you David,
Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/